Fix missing simpleicons-based windows logo by standalone version #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ralim
approved these changes
Jan 10, 2025
Collaborator
Ralim
left a comment
Ralim
left a comment
There was a problem hiding this comment.
I agree the simplest is to just have it in the repo in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO: @Ralim
CC: @gamelaster
TL;DR: for some reason since Window logo did disappear from simpleicons.org database, the easiest and the simplest way seems to just replace it with the local version for the table of supported devices.
Currently vs Patched.
It's strange but you can't find any windows nor microsoft related icons through simpleicons anymore. I did try to utilize
svgversion from fontawesome, like this:But this doesn't work with GitHub'based Markdown flavor (for security reasons to avoid malicious payloads and/or content from 3rd party sources which may be compromised, as far as I could understand).
So the straightforward option is to:
svgversion of fontawesome;svg;png;img/;img src=img/....Hence, here is the suggestion in this patch.
For the record, due to such kind of exact nuances I'm not a big fan myself of turning markdown files into html much (because the whole idea of markdown is not to be html much). But since there is a nicely done table already, this is a proposal fix for the broken window logo (sweet irony, punch intended :)
Let me know what you think.